member menu bug

This was tested in RC3 and RC 4 install and shows up in both..  The issue comes with the member menu bar.  When the bar is on the bottom everything is fine.  However, if you set the bar to the top or static and press the mail icon, a non-working contacts menu selection appears.  This contacts selection does not appear when the menu member is on the bottom,  Pictures:

As you see here everything is okay and appears how it should.

Now when we place the bar up top or top/static look at the extra menu item that appears:

This __contacts__ appeared on both the RC3 and RC4 installs, I did not test with other installs.  Can others confirm or deny that this contacts appears.

yes its a bug

tested on D7 RC 3

but i do have a fix for it let me know what you want pick 1.2.3 lol

http://www.boonex.com/trac/dolphin/ticket/1650

if you think about it there really isn't no need to have it at all it only shows how many ppl. you have sent mail to

 If you have a fix, can you post it here?

sure i can

it's just that i was waiting for him to see what he wants

take a look at  last two imgs.. one has the contacts the other doesn't

 One with contacts please!!

It appears contacts is supposed to be there but for whatever reason it isn't showing up as it is supposed to.  I choose 2 :)

files to edit

/templates/base/scripts/BxBaseMailBox.php

Step 1:

around line 1712-1719
find this code

$aNewMessages  = array();
$aLanguageKeys = array (
'sent'       => _t('_Sent'),
'compose'    => _t('_Compose new letter'),
'trash'      => _t('_Trash'),
'inbox'      => _t('_Inbox'),
);

and change to

$aNewMessages  = array();
$aLanguageKeys = array (
'sent'       => _t('_Sent'),
'compose'    => _t('_Compose new letter'),
'trash'      => _t('_Trash'),
'contacts'   => _t('_Contacts'),
'inbox'      => _t('_Inbox'),
);

------------------------------------------------------------------------------

next

around line 1731
//  generate member's new messages list ;

above that line add this code

$sQuery =
"
SELECT
COUNT( DISTINCT if(`Recipient` = {$iMemberId}, `Sender`, `Recipient`) ) AS `Contacts`
FROM
`sys_messages`
WHERE
`Sender` = {$iMemberId}
OR
`Recipient` = {$iMemberId}
";

// number of contacts ;
$iContacts = db_value($sQuery);

----------------------------------------------------------------------------

last stap

around line 1773-1784

$aExtraSection = array(
'go_inbox'       => $aLanguageKeys['inbox'],
'inbox_count'    => $iInboxCount,

'go_outbox'      => $aLanguageKeys['sent'],
'outbox_count'   => $iSentCount,

'go_compose'     => $aLanguageKeys['compose'],

'go_trash'       => $aLanguageKeys['trash'],
'trash_count'    => $iTrashCount,
);

change to

$aExtraSection = array(
'go_inbox'       => $aLanguageKeys['inbox'],
'inbox_count'    => $iInboxCount,

'go_outbox'      => $aLanguageKeys['sent'],
'outbox_count'   => $iSentCount,

'go_compose'     => $aLanguageKeys['compose'],

'go_trash'       => $aLanguageKeys['trash'],
'trash_count'    => $iTrashCount,

'contacts'       => $aLanguageKeys['contacts'],
'contacts_count' => $iContacts,
);

that's it

if you prefer no contacts in the menu

file to edit

/templates/base/mail_box_member_menu_messages.html

at the end just comment out this line of code

<div>
<img src="<bx_icon_url:memeber_menu_sub_contacted.png />" alt="__contacts__" width="16" height="16" /> __contacts__ (__contacts_count__)
</div>
</div>

Hello, we removed contacts section because that is unnecessary information

wasn't removed completely as you can see in /templates/base/mail_box_member_menu_messages.html it still calls for it

<div>
<img src="<bx_icon_url:memeber_menu_sub_contacted.png />" alt="__contacts__" width="16" height="16" /> __contacts__ (__contacts_count__)
</div>

but i do agree it's unnecessary to have it :)

You will see changes in next RC

Hello, 

Whenever i set my member menu setting's to "top" I cannot click on anything on my website. the only thing i can click on is the member menu, i need to set it back to the bottom of the page in order to use my site. im running the latest dolphin 7.0.9   A friend of mine tried it also and they had the same problem. Can someone please help? Is this an unresolved bug? When will it be fixed?

The custom template I was using is at fault, Not the dolphin 7 software. 

Not to mention that your inability to click on anything when the menu was at the top is not even within the topic of this forum post. Completely unrelated. The only thing in common was the position of the member menu. The symptoms however are completely different.

Also note the date the last post was made. 3 Years. This bug specific to this post was fixed over 9 versions ago. 3 years back when dolphin 7 was first being beta tested.

Please check dates on topics before you resurrect old posts such as this one.