for translation

hello

in the file

Dolphin-v.7.2.1\modules\boonex\groups\install\langs\en.php

value :

148             '_bx_groups_page_title_browse_by_author' => '\'s groups',

is good in english but in french this is inverted and others language same spanish, italian, Portuguese...

example :

english : Bob's groups
french : Les groupes de Bob

this value is used in

Dolphin-v.7.2.1\modules\boonex\groups\classes\BxGroupsSearchResult.php

111            $this->aCurrent['title'] = ucfirst(strtolower($sValue)) . _t('_bx_groups_page_title_browse_by_author');

line : 111

is possible change the value by

148            '_bx_groups_page_title_browse_by_author' => '{0}\'s groups',

where ucfirst(strtolower($sValue)) = {0}

if $sValue is the username

I think make the same change for

Dolphin-v.7.2.1\modules\boonex\groups\install\langs\en.php

149            '_bx_groups_page_title_browse_by_author_joined_groups' => '\'s joined groups',

149      '_bx_groups_page_title_browse_by_author_joined_groups' => '{0}\'s joined groups',
 
and

Dolphin-v.7.2.1\modules\boonex\groups\classes\BxGroupsSearchResult.php

156                $this->aCurrent['title'] = ucfirst(strtolower($sValue)) . _t('_bx_groups_page_title_browse_by_author_joined_groups');
 

regards

I am not understanding the issue, each language translation should take care of the differences automatically.

ucfirst(strtolower($sValue)) = the username of author joined groups

in english the meaning of the sentence is good. word order is correct.

but for tranlate in french or other language the sentence does not mean anything.

like my exemple

 ucfirst(strtolower($sValue)) = Bob

_bx_groups_page_title_browse_by_author' => '\'s groups',

in english the sentence "Bob's groups" is ok

but in french
Bob == ucfirst(strtolower($sValue))

_bx_groups_page_title_browse_by_author' => 'Les groupes de',

give this : "Bob Les groupes de" but is not correct !!!

correct sentence is "Les groupes de Bob"

ucfirst(strtolower($sValue)) must become a variable which must be added to the translation

regard

If the order is wrong, then it is because the translation string was not added correctly.  The person doing the translation must have not known French; which is why language translations should be done by a person that actually understands the language and not a translator such as Google Translate.

All you need to do is to edit the language string and move the {0}

You are looking at code, you don't need to look at the code; look at the language translation.

 
Sorry GG, need to step in on this one. Your misunderstanding the request.

The language key in question _bx_groups_page_title_browse_by_author does not support the use of a {0} because a variable is not passed in code. So he is asking for the code to be changed so a {0} can be used so it can be properly translated. His translation is accurate. It just cannot be accomplished due to a bug in the code.

@cereal_killer - To fix the issue, just Make the following code changes.

In modules\boonex\groups\classes\BxGroupsSearchResult.php at line 111.

Change this

$this->aCurrent['title'] = ucfirst(strtolower($sValue)) . _t('_bx_groups_page_title_browse_by_author');

To this

$this->aCurrent['title'] = _t('_bx_groups_page_title_browse_by_author', ucfirst(strtolower($sValue)));

Then at line 156

Change this.

$this->aCurrent['title'] = ucfirst(strtolower($sValue)) . _t('_bx_groups_page_title_browse_by_author_joined_groups');

To this

$this->aCurrent['title'] = _t('_bx_groups_page_title_browse_by_author_joined_groups', ucfirst(strtolower($sValue)));


Then you will be able to edit the language key _bx_groups_page_title_browse_by_author_joined_groups to use a {0} where you want the name to appear. English for example would be {0}\'s groups.

My mistake, I did not even notice where this was posted.  The whole Boonex forum is a mess; Boonex should separate out posts based on the forum.  And the bloody post was not clear in the first place.

And since this was in the bug forum why didn't Boonex stepped in and at least make a comment; it was two days ago so the excuse of being a weekend did not apply.

@deano92964

thank's but I know this fix

but if I use the english language or other on my site the problem is moving with their
is no possible to integrate the username in value to the tranlation string?

for this moment I don't can test it

I have don't install dolphin I make a translation before in french spanish en german

all translation on the market is very bad

Deano if I can resolve this I send you my result you can add to the next version of Dolphin?

I think use sprintf()

regard

@Geek_girl

when you read a post you can see this on top page

Forums > Suggestions > Bugs & Issues

my french tranlation is make by me not a google trad
and my question is related to the code and not just translation language

tank's all have a good day

The fix i provided does integrate the username. It passes the username value to the translation function so it can be incorporated as part of the translation string. So it is the solution.

Thank you for the report and thank you @deano for the fix:

https://github.com/boonex/dolphin.pro/issues/234

The problems has ben fixed:

https://github.com/boonex/dolphin.pro/commit/c3fa96c9a32f161078372044b7cf8457b3371402

thank's for that

very good

Hello AlexT

Same probleme with

module/boonex/paypal_payflow/install/lang/en.php

language key: '_bx_pfw_txt_shopping_cart' => '\'s cart',

regards

Thank you for the report - https://github.com/boonex/dolphin.pro/issues/409 

Hello

The problems were fixed:

https://github.com/boonex/dolphin.pro/commit/8dd3267be4dedf586609b554437798c188095dd0