You can add a "fave" but not remove one...?

I notice under member profiles, you can add a 'fave' or as I have changed to say "favorite" -- but once added, the button never changes to remove that person from your favorites.  If you click it twice, thinking the button text just has not updated, it simply adds the person a second time. A little bad on the intuitive side;  Is there any way to make that button switch over to REMOVE favorite once they are added?  

Not only is the redundant adding of a favorite troublesome... but so is the areas where the test does not fully display or size properly to viewed without the need to use the little arrows .... a lot of people, who are not web savvy, would never think to try that.

Hello

Looks like it's a defect in the default functionality and it should be fixed by BoonEx. However you may remove the profile from "Favourites List" via My Account -> Activity page -> Hot Lists tab.

Hello again.

Thanks for defect report. It was fixed in Dolphin 7.1.

Can this be fixed in 7.0.9 too?

 Hello

The fix can be applied to Dolphin 7.0.9 too. You may find it in SVN, rev17005. But I think you need to be a programmer or at least have some knowledge in PHP, MySQL and Dolphin structure to apply the changes.

Thanks Anton,

i can add these changes, no problem. But the question i worry about is if this 7.1 specific code is compatible with 7.09 and will not break it in other parts. If i just can apply without running into problems i will do it.

 Hello

You shouldn't have any problems because this code doesn't change any system parts. It just adds new button and modifies the existing one.  To be sure I've installed it on my demo Dolphin 7.0.9 and it's working fine.

The only thing you need to know.  You don't need to update the whole sys_objects_actions table. You just need to apply the MySQL query like the following.

UPDATE `sys_objects_actions` SET `Eval`='return $GLOBALS[''oTopMenu'']->getScriptFaveAdd({ID}, {member_id});' WHERE `Caption`='{cpt_fave}' LIMIT 1;
INSERT INTO `sys_objects_actions` (`Caption`, `Icon`, `Url`, `Script`, `Eval`, `Order`, `Type`, `bDisplayInSubMenuHeader`) VALUES ('{cpt_remove_fave}', 'action_fave.png', '', '{evalResult}', 'return $GLOBALS[''oTopMenu'']->getScriptFaveCancel({ID}, {member_id});', 3, 'Profile', 0);

Thanks for your help Anton.

I nearly finished changing the code but i cannot find the stuff for /templates/base/scripts/BxBaseMenu.php

It looks like this is not part of 7.0.9. What should i do?I thought i need skip this file because there is nothing about remove a fave anyway but now I think i need copy lots other stuff to my 7.0.9 files. For example in the sql statement you gave me there is a function call to getScriptFaveAdd() and getScriptFaveCancel(), these are the things i am missing.

Anton:

Thanks again for being an invaluable resource here with Dolphin!

 Hello

You are right BxBaseMenu.php file doesn't have getScriptFaveAdd() and getScriptFaveCancel() functions, but you need to add them only. You may take both of them from Dolphin 7.1 SVN

 Hello

 You are very welcome!!!

I think I will wait until 7.1 not being tech savvy, I am afraid to play with any coding.. at least until I have learned more.

<<sigh>>

At least a fix is coming!

Hi Anton,

I implemented all the codes and updated the sql. (Thanks for that btw!)

I am able to fave and unfave.

PROBLEM: At the homepage, After I fave, when I mouse over the user avatar to unfave, instead of the words 'Unfave', {cpt_remove_fave} appears instead.

I've checked my language keys and '_Remove Fave' = 'Unfave' is present.

The words 'Unfave' is also showing correctly when I go to the user's profile page.

So it's only at the mouse over avatar pop up box that the 'Unfave' is not showing.

Is something missing from the list_pop.php?

anyone else having problems with the {cpt_remove_fave} appearing in the avatar mouse-over pop up box after faving at the homepage?

you have to modify short_profile_info.php at line 35 you will see a list of all lang keys

Thanks Prashank!!

Added to short_profile_info.php at line 35:

    if(isMember()) {

        $aProfileInfo['cpt_edit'] = _t('_EditProfile');

        $aProfileInfo['cpt_remove_fave'] = _t('_Remove Fave'); //added
    }

    else {

        $aProfileInfo['cpt_edit'] = '';

        $aProfileInfo['cpt_remove_fave'] = ''; //added

    }

Solved! Thanks again to Prashank! :)