Remove white space after closing php tags

I have no idea how many php files in D7 have extra white space after closing php tags, but it's a lot.  It's nothing but a source of constant trouble.  Please make all the extra space go away.

They also have a mixture of line endings too.

/DM

It's often the cause of the commom "headers already sent...." warning.  I use CuteFTP to edit files directly on the server, and a lot of times after saving the file to the server after an edit, this warning appears.   Once I remove the extra space, everything's OK.  There's no reason to have this extra space, and at least one good reason not to have it.... so it may as well not be there.

CuteFTP one of the best  :)

Many editors will trim whitespace too

/DM

OK - on another related note.

There are missing closing php tags in many files too.

C'mon guys, this is just slap-dash.

/DM

Hello DeeEmm!

Now it isn't necessary to have close tags in files that contain only PHP. http://framework.zend.com/manual/en/coding-standard.php-file-formatting.html

Regard

Leonid: well on hotgator its a problem ..took me about 1 week to find out (Im not programmer) Im getting error on some mod installation because of missing closing tags in lang files. So apparently on some hosts it can cause problems and in some files because white space...

RE:

What?   I don't get a hello?  It's my thread... and I don't get a hello?  I'm crushed :'(

So LeonidS....  why didn't you write a ticket on this?

I have found that white space at the end of the php file generally does not matter as long as the line endings are proper. CRLF for Windows, LF for Linux and MacOS X

I suspect the cause of the mismatch of line endings, some of which contain double line feeds with one carriage return is the boonex staff works on the dolphin code with different platforms. Some of them running macs while others running windows. The work performed on more than one platform causing a problem with the line endings.

This can easily be cleaned on any linux box where you have shell access. The commands dos2unix and unix2dos will cleanup most files.

My FTP client WSFTP Pro also does it, but doing it via FTP is a bit slow.

In my opinion two archives should be released for dolphin. One with ascii files such as the php files formated for linux. And one formated for windows. By doing so, it should eliminate such problems with line endings and extra white space.

What if we just added the closing tags in each file; would that help or hurt the functionality?

This forum thread was from 2010.  If you are having issues, please start a new thread and we will help.

Yea, this is a very old thread. The newer version of Dolphin 7.1 no longer have closing tags to avoid that problem. So if your getting that error then that is not the cause.