Member menu items become pop-ups

I have done  fresh install of Dolphin 7.0.1 and when I create new member menu items, these items are always pop-ups. Even when I specify that the link should open in the same window

Am I the only one with this issue?

No replies and it's not in trac

Hello provide us with screen shots or your site url

Sorry, but how is posting a screenshot or site url going to make a difference?

There must be someone who tried to add a new item to the member menu (Admin, Builders, Member menu) and found that the new items come up as pop-ups?

Maybe see ticket http://www.boonex.com/trac/dolphin/ticket/1700#comment:3

@MichelSwiss

I checked the issue you mentioned but this is not the case. The target field is filled with data, so not stripped.

What I did to get the produce the issue is the following:

1. Open Admin Panel, Builders, Member Menu
2. Click "Top Extra"
3. Add "New Item"
4. Fill in the details:
   •  system name: Chat MM
   • Language key:  _chat_top_menu_item
   • Default name: Chat
   • URL: m/chat/home/
   • Script:
   • Icon: bx_chat.png
   • Target Window: Same
5. Save Changes
6. Go to the homepage and now click on the newly created icon - The chat will open in a new window.

To solve the issue in my case, I changed in BxDolMemberMenu.php

'target'                         => ( $aItems['Target'] ) ? 'target="_blank"' : null

to

'target'                         => ( $aItems['Target'] == '_blank' ) ? 'target="_blank"' : null

The reason why I changed this ... `Target`      - the "target" attribute for the link (for example, "_blank" will open the link in a new window);
But the code says "If target is set than target is blank, else do not set target"

I changed this to: "If target is set and target is set to '_blank" than target is blank, else do not set target".

Thank you for detailed report.

http://www.boonex.com/trac/dolphin/ticket/2047

@Denre/AlexT - Yes I had this problem and came up with a workaround for it until the code is fixed.  As Denre pointed out, I noticed that when I created a new active item in the top extended member menu builder - AND SELECTED SAME AS THE TARGET WINDOW - it opened in a new window.  The problem seems to be with that "Edit Item" screen.  You have to choose one or the other, Same or New - both reasonable choices in particular circumstances.  But if you choose Same, that action doesn't seem to be correctly defined.  In PhpMyAdmin, sys_menu_builder, Target shows _self, which should open it in the same window  To get the link to open in the same window I had to clear that field (I.E. leave it empty).

Denre, I'm not sure if your code fix addresses this selection issue in the "Edit Item" screen.  In fact, if you edit another field in the "Edit Item" screen and save it again with Same as the window choice, the identical thing will occur: _self will be added to the Target field and you'll have to delete it again.  Obviously, someone may want to open it in a New window, so you can't eliminate the selection.

Would like to know if Denre's fix does resolve this.  Otherwise, I hope this helps point to a solution.

Trouble where fixed!

@124c41plus

When you modify an item the target field gets filled and because of that it will become a pop-up.