Changes to header.inc file during upgrade error

I have a site I'm trying to upgrade, which seemed to all work until this part.

• Change the following line from:

  require_once(BX_DIRECTORY_PATH_INC . "security.inc.php");

  to:

  require_once(BX_DIRECTORY_PATH_INC . "version.inc.php");

To make the update links for these

• Click here to update Wall module handlers and Shoutbox objects
• Click here to resize images from Photos module to the new dimentions

I had this error,

Warning: require_once(/home/website/public_html/inc/version.inc.php): failed to open stream: No such file or directory in /home/duvallocals/public_html/inc/header.inc.php on line 158

Fatal error: require_once(): Failed opening required '/home/website/public_html/inc/version.inc.php' (include_path='.:/usr/share/php:/usr/share/pear') in /home/website/public_html/inc/header.inc.php on line 158

Which is these lines..

Line - 157   //require_once(BX_DIRECTORY_PATH_INC . "security.inc.php");

Line - 158   require_once(BX_DIRECTORY_PATH_INC . "version.inc.php");

The links worked and updated the handlers and the photos resized.

I then made the changes as requested in 

website.com/upgrade/?folder=7.1.6-7.2.0

Change  security to version, it breaks the site.

Apply the security line back the site seems to work just fine.

The site has other modules, this is a test upgrade.

What is the reason for the line change? Oblivious it is another module I would think.

Input please...

Version information is moved to /inc/version.inc.php. It should have been added when you upgraded. If not, something's wrong with the upgrade.

OK, thanks, will look at that.

The permissions for /inc were set to 555 like requested for 7.0.* +.

So we need to make sure the folder is writable when doing an upgrade.

[update edit] Manually uploaded the version.inc.php file and that corrected the error.

If that is the case, then a whole lot of sites is going to be hit by this problem. Perhaps the upgrade script should check the folder permissions ahead of time and report to the user.

 https://github.com/boonex/dolphin.pro/issues/69

Wow this issue is still in the default download for 7.1.6 to 7.2 patch file. I also had to create my own file. Hopefully setting permissions to 555 is what I need to do.

AlexT thinks this is NOT a problem.

I guess he has not experienced it first hand.

This is what he says..

Owner

AlexTr commented 2 days ago

If you have incorrect permission, then you will fail when you copy over the files. So you should get some error from FTP client or in SSH command line.

AlexT thinks this is NOT a problem.

I guess he has not experienced it first hand.

This is what he says..

newton27 commented 2 days ago

What about my case, or others that have the /inc set to 555. It affected me and has others. Why don't the switch or upgrade check that folder permission?

 

Owner

AlexTr commented 2 days ago

If you have incorrect permission, then you will fail when you copy over the files. So you should get some error from FTP client or in SSH command line.

Tell Alex that uploading files through a shell account where you have root permissions is different than running scripts through the web browser; he must not have thought of that when he made his comment.

 No.

Before the upgrade from 7.1.6 to 7.2 you need to check to see if /inc is at 555.

If it is it needs to be set at 755 BEFORE the upload of the upgrade files.

I understand what Alex says about an error, I was using Filezilla, if there were errors they were overlooked.

Most members are not so SSH savvy in this area. 

The most simple solution is to freaking add a few more lines to the upgrade instructions on this site!