PKForum Support (DolphinHelp) - part 2

I got this error several time

Database error in 'Domain'

Query:

SELECT `t`.`ID`, `t`.`OwnerId`, `p`.`Subject`, `t`.`Url`, `t`.`Status`, `t`.`ForumId`, `t`.`Locked` FROM `dh_pkforum_topics` AS `t`
            INNER JOIN `dh_pkforum_posts` AS `p` ON `t`.`ID` = `p`.`TopicId` WHERE `t`.`Url` = ''   this.href   ''
	    AND `p`.`ID` = (SELECT `ID` FROM `dh_pkforum_posts`
	    WHERE `TopicId` = `t`.`ID` ORDER BY `ID` ASC LIMIT 1) LIMIT 1

Mysql error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'this.href '' AND `p`.`ID` = (SELECT `ID` FROM `dh_pkforum_posts` W' at line 2

Found error in the file '.../public_html/modules/dh/pkforum/classes/DHPKForumDb.php' at line 317.
Called 'getRow' function with erroneous argument #0.

SELECT `t`.`ID`, `t`.`OwnerId`, `p`.`Subject`, `t`.`Url`, `t`.`Status`, `t`.`ForumId`, `t`.`Locked` FROM `dh_pkforum_topics` AS `t`
            INNER JOIN `dh_pkforum_posts` AS `p` ON `t`.`ID` = `p`.`TopicId` WHERE `t`.`Url` = ''   this.href   ''
	    AND `p`.`ID` = (SELECT `ID` FROM `dh_pkforum_posts`
	    WHERE `TopicId` = `t`.`ID` ORDER BY `ID` ASC LIMIT 1) LIMIT 1

 Where you got that and what were you trying to do? Its not supposed to happen :/

 I am a member of a mailing list for Blues music and i wanted to paste that email to the forums....well it gave me an error that the message must be between 2 and 10,000 characters..... wouldn't let me save the pasted message.Added to issue list, We will set the max limit to 65535 characters in next minor version.

For now, you can update some files to get it to work.

min-value="3" max-value="10000"

change that to

min-value="3" max-value="65535"

in these files:

dh/pkforum/templates/base/add_topic.html
dh/pkforum/templates/base/post_reply.html
dh/pkforum/templates/base/edit_post.html 

I don't know, just got that error report. 

this.href missing, so I think when forum's member try to load one link, the one missing this.href. Must have to check valid href before pass it to query.

SELECT `t`.`ID`, `t`.`OwnerId`, `p`.`Subject`, `t`.`Url`, `t`.`Status`, `t`.`ForumId`, `t`.`Locked` FROM `dh_pkforum_topics` AS `t`
            INNER JOIN `dh_pkforum_posts` AS `p` ON `t`.`ID` = `p`.`TopicId` WHERE `t`.`Url` = ''   this.href   ''
	    AND `p`.`ID` = (SELECT `ID` FROM `dh_pkforum_posts`
	    WHERE `TopicId` = `t`.`ID` ORDER BY `ID` ASC LIMIT 1) LIMIT 1

I have another idea:

it would be very good step to have a choice to add/not add

rel "nofollow" attribute

to all links in member's posts and signatures.

Hmm...so you got that in an email error reports. So i think someone is trying to insert some js into your database, which is known has "xss". Well its protected so they will fail. You can safely ignore it 

Really? I hope so :)

 Did what you suggested and still same error   3 to 10,000 limit......... do i need to flush cache or anything ?

  This time i tried to insert a Picture and the error came..............

Try flushing the cache and not inserting an image.  Also, using http://charactercounttool.com/, report how many characters you're putting in a single post when it fails.  

Regarding the photo insert error... what size did you try to insert, e.g. a 10MB .bmp file?

 jpg = 141KB

That's rather odd... never happened during development testing.  Please take a screenshot of the error message and send it to me.  Just to clarify, this happened while inserting an image located on another server?  If so, send me the image URL so I can test it.  If not, then send me the image.  Thanks :-)

 That email ( txt 1 )i was trying to post was  "Character Count: 28628"

1) send me the photo you're trying to insert (or URL for it)

2) send me the text that you're trying to insert... in a plain text file.

I'll test it on the demo site after making the changes Prashank suggested.

Thanks

 http://www.ottawasucks.ca/StAnthony.jpg

txt link  http://www.ottawasucks.ca/StAn.txt

Facebook share problem.

I know this really isn't PK's fault but I need to solve this problem. When you try and share a post, if there isn't a properly sized image, it will terribly hack up the forums banner image or use a slice of an image from within the post. How do I force the forum to properly size and keep the existing aspect of an image?

Example:

Text should work now, you can probably try clearing your templates cache.

Inserting only the images does not work cuz tinymce doesn't return html so its not counted, i think i will change that in next version. But you can try adding 3 letters with the image or toggle the tinymce editor then submit.

 Ok will clean cache and give her a go..

Thanks

Recent posts block is reporting the same post twice.

I created a post on making a banner ad. I then went back in and edited the post. Now it shows in the recent posts mod twice.... it is the same post...

Nop, somehow you managed to add 2 topics, maybe you clicked submit twice. I am not sure, delete the other one and let me know if it happens again.

EDIT: Now i am guessing, after adding the topic you thought of editing it and clicked the browser back button? Then you edited it and saved it again. Well you actually reposted it so better to use edit button next time :|

Yeah, I would do that if Tinymce didn't delete everything I placed in quotes each time I edit twice.... Have you ever seen that? I can recreate it at will.

If I place some text between quotes "some text" then save, the text and quotes show fine. If I then edit the post, everything between the qoutes marks disappears..... The only way to successfully edit a post with quotes in it is to backup to the first edit....

LOL!

(I did not realize it created a second post)

BTW, it sure would be easier if the editor allowed you to insert an image directly into the signature editor box.....

now you want a tinymce for signature field too :o

btw please post the exact step by step instruction to recreate the quote issue or make a video...

Actually, I need to be more clear on that.

If I place a tag reference between quotes, it happens. Lets say I add

"<a href="http://mydomain.com"><mydomainname</a> then save, the entire string shows up. If I go back and edit it, it then tries to convert it to a link... ..... There is no way to place an actual string that it does not try and convert.... In other words, in this editor, I can place it in between a 'code' style and maintain the structure"

<a href="http://mydomain.com">mydomain</a>

Thanks for the report, some things still get missed even in extensive testing...

Anyway, a fix has been applied already, we will test it more and it will be included in next minor version.

Coolio! I didn't imagine it would be a very big deal but all of us here LOVE the fact that you never leave your com.....

Well YEAH! I have been asking for a proper signature line for a long time. My users are all tow truck drivers. Most of them can barely turn on their com unit and asking them to figure how to add an herf tag, or even understand what it is, is really stretching it.

They like to add their tow company banners to the site and I like it because of the increased SEO placement (you know, friendly links back and forth and so forth)

While I'm at it here, I would like to add the upgraded photo upload feature tinymce provides, can you direct me to the proper link to download it?

 The one that's already included in the install package?  Did you turn on the feature in the PKF admin settings?

Yes. I am talking about the full blown MCImageManager. I installed it in my Orca some time ago but the file structure of PKForum is different. I need a little help getting it to work... I like the idea that my members can upload directly to their posts and create their own folders to store and reuse images out of.

 Do the same steps you did for orca except the file will be /modules/dh/pkforum/classes/DHPKForumTinymceEditor.php

The files are too different and I don;t understand. I can;t even find the poriginal post that explained in detail how to add it in. I have mcimagemanager but there's a new version now called moxie manager that costs a lot more money.

If it didn't take 6 years to get a properly operating forum to replace Orca, I wouldn't be having this issue.

SkyForum... check out http://www.boonex.com/m/ImageManager_plugin_integration

Installing it in the dolphin script is easy as mine is already there. I just can't figure out how to make it all work in pkforum....

 just pm me your ftp and admin logins, i will add it.

Can I migrate current data from a phpbb3 database to Pkforum?  Such as posts, users etc...

Well... I'd imagine someone very good at moving data from one db scheme to another could figure it out but it would require a fair bit of time to write the queries and test them for both accuracy and completeness.  Unfortunately Prashank is extremely busy with programming work so I don't foresee him having time to help.  Which leaves me thinking if you can't find a db guru to help then you may have to decide whether to continue with PHPBB3... or start fresh with PKForum. 

Interestingly, I rebuilt an old ASP-coded site two years ago, with Dolphin D7.0.9, where I opted to provide links to the old forum (old version of phpBB) so people could still access that info... and started fresh with the one built into Dolphin, i.e. Orca_Forum.

Is anyone using PK with a responsive template?

I've noticed a couple of issues with mine and would like to verify if its just my site.

I had an issue where a post was overlapping the page width.

First realised it was the image width, where the imported image using pk's upload image feature, was fixed width and not responsive.

changed that using html to 100%, looks fine on mob, but any smaller images will then be blown up to full width on desktop...

then the forum post content on iphone was showing a margin down the right hand side so text would not fill the screen.

found the setting in pkforum/templates/base/css/forum_responsive.css

where

.boxContent .pkforum-topic-posts-content {

width: 80%;

padding: 0px;

    }

Changed to 100% and looks much better. Text now fills the width of screen on mobiles nicely.

Looks fine on desktop also.

Is there a reason this should be 80%? 

Any ideas on making the uploaded images responsive as anything wider than mobile resolution kinda 'breaks' the viewing experience of a post on a mobile.

i don't remember exactly why i did that but must be a reason i guess, anyway if it works for you then keep it that way. We knew responsive might not work for everybody, all templates are pretty different.

for image issue try adding this in the bottom of the css file.

img {
    max-width: 100%;
    height: auto;
} 

Quick question.

I have a very lengthy list of forums in some of my categories.

Is this possible in this version or future versions: when someone clicks on "+ Add Topic" instead of having 1 dropdown box listing everything (very long list of cats and forums), have 1 dropdown box for categories, followed underneath by a 2nd dropdown box for forums within that category only?

Jeff

A facebook share issue; I need help with the following. So far, PKForum has been stellar in it's performance and I'm not sure this is a PK problem.

When I do a Facebook share on a topic, I get the 'javascript:void' as shared by

Bill, I'll test it to see if I can duplicate the issue. Paul

Okay... I was able to duplicate it. I'll see if I can fix it on the demo site.  Paul

Bill, I looked at the Sharethis site along with Prashank's code and can find nothing obvious that might be causing the problem.  My best guess is the problem is outside of PKForum and something to do with how Sharethis is "feeding" Facebook. 

I sent an email to Sharethis support informing them of the issue and asking for feedback.

Paul

Thank you!

Bill... Prashank solved the ShareThis issue by removing the author meta tag.  An update will be posted soon so you can start using ShareThis without the "BY JAVASCRIPT:VOID(0)" issue.

You guys are terrific. Thanks....

Is it possible to integrate PKForum with my groups?

 not yet, most probably after we do the support for 7.0.x.

Ok, here's a new one. I'm not sure you can call it a bug because it's a result of me enabling the tinymce image manager.

If a user uploads an image that's too wide for the post, it stretches the page to a point that you cannot get to the edit post link to resolve it. (Gets pushed off the right side of the page). I had to enter the edit page link manually in the toolbar to get the editor opened up so I could replace (and downsize) the images....

I guess what I really need is a way to get to that link if this happens or better yet, a way to make sure images that are too wide are resized before they are posted so they fit within the constraints of the page.... Not sure how I can do that. Ultimately, I would like all images resampled and resized before they are added to the post but io know that's asking a lot.